Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: status cmd repeats until killed by 11 *different* signals #1207

Merged
merged 3 commits into from Oct 21, 2021

Conversation

epruesse
Copy link
Contributor

@epruesse epruesse commented Oct 7, 2021

I'm pretty sure the code wasn't intended to only abort if the status cmd was killed by more than 10 different signals.

Description

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

I'm pretty sure this wasn't meant to only abort if the status cmd was killed by more than 10 *different* signals.
@epruesse epruesse requested a review from johanneskoester as a code owner Oct 7, 2021
@epruesse epruesse changed the title Count times status_cmd killed by same signal fix: status cmd repeats until killed by 11 *different* signals Oct 7, 2021
Copy link
Contributor

@johanneskoester johanneskoester left a comment

Right, good catch :-)!

@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester merged commit 8b28b57 into snakemake:main Oct 21, 2021
6 checks passed
pvandyken pushed a commit to pvandyken/snakemake that referenced this pull request Nov 15, 2021
…make#1207)

* Count times status_cmd killed by same signal

I'm pretty sure this wasn't meant to only abort if the status cmd was killed by more than 10 *different* signals.

* fix typo (yes, "extend" and "append" are right next to each other)

Co-authored-by: Johannes Köster <johannes.koester@uni-due.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants