Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: caching process #1225

Merged
merged 7 commits into from Oct 20, 2021
Merged

Conversation

jafors
Copy link
Contributor

@jafors jafors commented Oct 19, 2021

Description

This PR fixes a bug in caching of rules. First, it adds an encoding step in hash.py which is required before updating the cache.
Second, it adds the sourcecache argument to the call of wrapper.get_script() in the hash.py

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@jafors jafors requested a review from johanneskoester as a code owner Oct 19, 2021
@jafors jafors changed the title Fix caching process Fix: caching process Oct 19, 2021
@jafors jafors changed the title Fix: caching process fix: caching process Oct 19, 2021
@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@johanneskoester johanneskoester merged commit 0825a29 into snakemake:main Oct 20, 2021
6 checks passed
wrapper.get_script(job.rule.wrapper, prefix=workflow.wrapper_prefix),
wrapper.get_script(
job.rule.wrapper,
sourcecahce=job.rule.workflow.sourcecache,
Copy link
Contributor

@mbargull mbargull Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo:

Suggested change
sourcecahce=job.rule.workflow.sourcecache,
sourcecache=job.rule.workflow.sourcecache,

. Apparently the test suite didn't catch this -- @jafors, could you add a test so we could get coverage here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants