Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: env file usage after changes to source file handling (inspired by #1233 and #1211). #1236

Merged
merged 4 commits into from Oct 26, 2021

Conversation

johanneskoester
Copy link
Contributor

@johanneskoester johanneskoester commented Oct 26, 2021

Description

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@johanneskoester johanneskoester changed the title Fix env file usage after changes to source file handling. fix: env file usage after changes to source file handling (inspired by #1233). Oct 26, 2021
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester changed the title fix: env file usage after changes to source file handling (inspired by #1233). fix: env file usage after changes to source file handling (inspired by #1233 and #1211). Oct 26, 2021
@johanneskoester johanneskoester merged commit 3ac8e85 into main Oct 26, 2021
7 checks passed
@johanneskoester johanneskoester deleted the fix-env-file-usage branch Oct 26, 2021
pvandyken pushed a commit to pvandyken/snakemake that referenced this pull request Nov 15, 2021
…snakemake#1233 and snakemake#1211). (snakemake#1236)

* fix: more informative nothing to be done message

* fmt

* fmt, fixes and additional tests

* implement fspath
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant