Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for machine_type for kubernetes executor #1291

Merged
merged 8 commits into from Mar 20, 2022

Conversation

cademirch
Copy link
Contributor

@cademirch cademirch commented Dec 1, 2021

Description

Quick little feature addition so that Snakemake respects the machine_type resource specification when using the Kubernetes executor. See #1278.

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@cademirch cademirch requested a review from johanneskoester as a code owner Dec 1, 2021
Copy link
Contributor

@johanneskoester johanneskoester left a comment

Thanks a lot! Can you please also add this to the kubernetes section in the snakemake docs?

@sonarcloud
Copy link

sonarcloud bot commented Dec 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cademirch
Copy link
Contributor Author

cademirch commented Dec 9, 2021

Thanks a lot! Can you please also add this to the kubernetes section in the snakemake docs?

Done! 40a5d31

@cademirch
Copy link
Contributor Author

cademirch commented Jan 5, 2022

@johanneskoester gentle bump on this. Let me know if you need anything else to close this PR.

@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester
Copy link
Contributor

johanneskoester commented Mar 18, 2022

Thanks, very good idea! Can you please run black on the changed file for the formatting?

@sonarcloud
Copy link

sonarcloud bot commented Mar 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester merged commit 12d6f67 into snakemake:main Mar 20, 2022
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants