feat: Support for machine_type for kubernetes executor #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanneskoester
requested changes
Dec 9, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Done! 40a5d31 |
|
@johanneskoester gentle bump on this. Let me know if you need anything else to close this PR. |
|
Kudos, SonarCloud Quality Gate passed!
|
johanneskoester
approved these changes
Mar 18, 2022
|
Thanks, very good idea! Can you please run black on the changed file for the formatting? |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quick little feature addition so that Snakemake respects the
machine_typeresource specification when using the Kubernetes executor. See #1278.QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).