Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with duplicated prefix for checkpoints on cloud #1294

Merged
merged 3 commits into from Feb 21, 2022

Conversation

aryarm
Copy link
Contributor

@aryarm aryarm commented Dec 8, 2021

Implements a test to reproduce issue #574: checkpoints in cloud execution mode.

Note: this PR duplicates #1199.

Once I'm able to reproduce the issue, I'm planning on using this PR to fix it.

Update (1/14/22): This PR now also resolves #574
See #574 (comment) for a description of the bug and the solution that I implemented.

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

to reproduce a problem with the use of checkpoints in cloud environments
@sonarcloud
Copy link

sonarcloud bot commented Dec 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aryarm
Copy link
Contributor Author

aryarm commented Dec 8, 2021

nice! it looks like the test failed properly

I should have some time in the coming weeks to try some fixes.

@johanneskoester
Copy link
Contributor

johanneskoester commented Dec 9, 2021

Thanks a lot for giving this a try!!

@sonarcloud
Copy link

sonarcloud bot commented Jan 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aryarm aryarm changed the title test: issue with duplicated prefix for checkpoints on cloud fix: issue with duplicated prefix for checkpoints on cloud Jan 14, 2022
@aryarm
Copy link
Contributor Author

aryarm commented Jan 14, 2022

@johanneskoester, the tests passed. It's ready for you to take a look!

#574 (comment) has a description of the bug and the solution that I implemented.

@johanneskoester
Copy link
Contributor

johanneskoester commented Feb 21, 2022

Thanks a lot for fixing this long standing bug!

@johanneskoester johanneskoester merged commit 8ed0c8c into main Feb 21, 2022
10 checks passed
@johanneskoester johanneskoester deleted the fix/duplicate-prefix-checkpoints branch Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default remote prefix duplicated for checkpoint output on cloud
2 participants