Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for post deploy scripts #1325

Merged
merged 18 commits into from Jan 14, 2022
Merged

feat: support for post deploy scripts #1325

merged 18 commits into from Jan 14, 2022

Conversation

johanneskoester
Copy link
Contributor

@johanneskoester johanneskoester commented Jan 11, 2022

Description

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2022

Please format your code with black: black snakemake tests/*.py.

@FelixMoelder FelixMoelder marked this pull request as ready for review Jan 12, 2022
@FelixMoelder
Copy link
Contributor

FelixMoelder commented Jan 12, 2022

This should be ready now.
Mind that I mentioned snakemake version 6.14. So in case the final release will be a different version we should change that.

docs/snakefiles/deployment.rst Outdated Show resolved Hide resolved
docs/snakefiles/deployment.rst Outdated Show resolved Hide resolved
docs/snakefiles/deployment.rst Outdated Show resolved Hide resolved
snakemake/deployment/conda.py Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester merged commit e5dac4f into main Jan 14, 2022
6 checks passed
@johanneskoester johanneskoester deleted the conda-post-deploy branch Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants