Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug in pipe group handling that led to multiple assignments of the same group id to different groups; bug that accidentally added already running groups of the list of ready jobs (issue #1331) #1332

Merged
merged 8 commits into from Feb 18, 2022

Conversation

Maarten-vd-Sande
Copy link
Contributor

@Maarten-vd-Sande Maarten-vd-Sande commented Jan 13, 2022

Description

The failing tests of issue 1331

@Maarten-vd-Sande Maarten-vd-Sande changed the title MRE + test issue 1331 test: MRE + test issue 1331 Jan 14, 2022
@Maarten-vd-Sande Maarten-vd-Sande changed the title test: MRE + test issue 1331 test: MRE of issue 1331 Jan 14, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

…he same group id to different groups; bug that accidentally added already running groups of the list of ready jobs
Copy link
Contributor

@johanneskoester johanneskoester left a comment

Thank you so much for providing the testcase. It took me half a day and was really a pain, but I managed to fix the bug!

@johanneskoester johanneskoester changed the title test: MRE of issue 1331 fix: bug in pipe group handling that led to multiple assignments of the same group id to different groups; bug that accidentally added already running groups of the list of ready jobs (issue #1331) Feb 18, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester merged commit 1a9b483 into snakemake:main Feb 18, 2022
7 checks passed
@iamh2o
Copy link
Contributor

iamh2o commented Feb 28, 2022

Awesome- I will give it a test drive soon. Will save me from a pretty gnarly patched production deployment I've been working with :-)

thank you--
john

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants