Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: specify conda environments via their name #1340

Merged
merged 14 commits into from Jan 25, 2022
Merged

Conversation

johanneskoester
Copy link
Contributor

@johanneskoester johanneskoester commented Jan 20, 2022

Description

This replaces #494 with an object oriented solution.

TODO

  • implement CondaEnvNameSpec
  • add test cases

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

snakemake/jobs.py Show resolved Hide resolved
@nh13
Copy link
Contributor

nh13 commented Jan 20, 2022

Thank you for making this feature, even though it’s not 100% aligned with the goal of reproducibility. I appreciate the pragmatism!

And my apologies as I would not have been able to figure this myself without more explicit help understanding the code, but it will help my understanding for any future contributions.

@johanneskoester johanneskoester changed the title feat: specify conda environments via their name (preparation) feat: specify conda environments via their name Jan 21, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester merged commit 735ab23 into main Jan 25, 2022
6 checks passed
@johanneskoester johanneskoester deleted the conda-env-by-name branch Jan 25, 2022
@nh13
Copy link
Contributor

nh13 commented Jan 25, 2022

Thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants