Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Draft notebook filename with wildcards and params. #1352

Merged
merged 2 commits into from Jan 28, 2022

Conversation

bilke
Copy link
Contributor

@bilke bilke commented Jan 26, 2022

Closes #1351.

Description

Also fixed report generation with notebooks containing wildcards or params.

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
    • I do not know how I can test for the originally failing use case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@bilke bilke requested a review from johanneskoester as a code owner Jan 26, 2022
@bilke bilke changed the title notebook: Fix draft notebook filename with wildcards and params. fix: Draft notebook filename with wildcards and params. Jan 26, 2022
@bilke bilke force-pushed the fix-notebook-draft-wildcards branch from a664b4c to d71efa4 Compare Jan 26, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester merged commit 11d4dc8 into snakemake:main Jan 28, 2022
7 checks passed
@bilke bilke deleted the fix-notebook-draft-wildcards branch Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wildcards and params in notebook directive not evaluated with --edit-notebook
2 participants