Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't raise WorkflowError when entry is empty #1368

Merged
merged 1 commit into from Feb 5, 2022

Conversation

vinisalazar
Copy link
Contributor

@vinisalazar vinisalazar commented Feb 2, 2022

Hi, this is in relation to #1367.

Summary of changes:

  • Modify function 'check_output_duplicates' to check for empty value
  • Complete docstring
  • Add period at the end of raise message

Description

Fixes the aforementioned issue. I ran pytest (skipped test_tibanna which was failing due to lack of credentials) and all tests passed.

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

  - Modify function 'check_output_duplicates' to check for empty value
  - Complete docstring
  - Add period at the end of raise message
  - Closes snakemake#1367
@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@johanneskoester johanneskoester left a comment

Thanks, good catch!

@johanneskoester johanneskoester merged commit 1fc6f7b into snakemake:main Feb 5, 2022
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants