Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert conda env to string before checks #1382

Merged
merged 2 commits into from Feb 9, 2022

Conversation

MSamman
Copy link
Contributor

@MSamman MSamman commented Feb 8, 2022

Description

PR to resolve #798. Convert pathlib to string before running checks on conda_env.

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@MSamman MSamman requested a review from johanneskoester as a code owner Feb 8, 2022
@MSamman MSamman changed the title convert conda env to string before checks fix- convert conda env to string before checks Feb 8, 2022
@MSamman MSamman changed the title fix- convert conda env to string before checks fix: convert conda env to string before checks Feb 8, 2022
@MSamman MSamman force-pushed the conda-env-pathlib-support branch from a2d0a33 to 76c5a2e Compare Feb 8, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester merged commit 7a8da9f into snakemake:main Feb 9, 2022
7 checks passed
@MSamman MSamman deleted the conda-env-pathlib-support branch Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pathlib error when specifying conda env
2 participants