Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cluster sidecar #1397

Merged
merged 1 commit into from Feb 17, 2022
Merged

Conversation

holtgrewe
Copy link
Contributor

@holtgrewe holtgrewe commented Feb 15, 2022

Description

This PR adds a new argument --cluster-sidecar argument, as documented. This is necessary to implement a REST server as as a caching layer for --cluster-status queries, for example. See Snakemake-Profiles/slurm#81 for an example use case.

based on #1395, should be rebased once that is merged

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@holtgrewe holtgrewe requested a review from johanneskoester as a code owner Feb 15, 2022
@holtgrewe holtgrewe changed the title Cluster sidecar feat: cluster sidecar Feb 15, 2022
@holtgrewe
Copy link
Contributor Author

holtgrewe commented Feb 15, 2022

🎉

@johanneskoester
Copy link
Contributor

johanneskoester commented Feb 17, 2022

PR #1395 is merged, I guess you can rebase this now.

@holtgrewe
Copy link
Contributor Author

holtgrewe commented Feb 17, 2022

OK, rebased / actually cherry-picked.

@sonarcloud
Copy link

sonarcloud bot commented Feb 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester merged commit b992cd1 into snakemake:main Feb 17, 2022
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants