Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not pass SNAKEMAKE_PROFILE into cluster-submit (#1398) #1407

Merged
merged 3 commits into from Feb 18, 2022

Conversation

holtgrewe
Copy link
Contributor

@holtgrewe holtgrewe commented Feb 17, 2022

Description

Resolved #1398 by not passing SNAKEMAKE_PROFILE into the cluster submission.

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@holtgrewe holtgrewe requested a review from johanneskoester as a code owner Feb 17, 2022
@johanneskoester
Copy link
Contributor

johanneskoester commented Feb 17, 2022

Can you fix the conflict, both commits are your code I think.

@holtgrewe
Copy link
Contributor Author

holtgrewe commented Feb 17, 2022

should be done

@sonarcloud
Copy link

sonarcloud bot commented Feb 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester merged commit 7189183 into snakemake:main Feb 18, 2022
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNAKEMAKE_PROFILE environment variable does not play well with Slurm
2 participants