Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: in google live science backend, save multiple logs per rule name and overwrite existing logs #1504

Merged
merged 7 commits into from Mar 23, 2022

Conversation

cademirch
Copy link
Contributor

@cademirch cademirch commented Mar 20, 2022

Description

This makes slight changes to the google_lifesciences_helper.py script to make GSL logs more helpful. These changes make GSL logs overwritten if present, saved per job_id to allow separation between multiple instances of the same rule, and have a .txt type so that they can be viewed easily in the browser.

See also #1485

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@cademirch cademirch requested a review from johanneskoester as a code owner Mar 20, 2022
@cademirch cademirch marked this pull request as draft Mar 20, 2022
@cademirch cademirch marked this pull request as ready for review Mar 21, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester changed the title GSL: Save multiple logs per rule name and overwrite existing logs fix: in google live science backend, save multiple logs per rule name and overwrite existing logs Mar 23, 2022
@johanneskoester johanneskoester merged commit 9e92d63 into snakemake:main Mar 23, 2022
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants