Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update for minimum of Python 3.7 #1509

Merged
merged 1 commit into from Mar 23, 2022

Conversation

jdblischak
Copy link
Contributor

@jdblischak jdblischak commented Mar 22, 2022

Description

tl;dr As of fd5daae, snakemake requires Python 3.7. This PR updates any reference to previous versions

I came to the GitHub repo to determine the minimum required Python version to run Snakemake, and I quickly got confused. The README displays Python 3.5:

Screen Shot 2022-03-22 at 2 48 08 PM

But setup.py clearly requires Python 3.7+

snakemake/setup.py

Lines 14 to 16 in 5f7170e

if sys.version_info < (3, 7):
print("At least Python 3.7 is required for Snakemake.\n", file=sys.stderr)
exit(1)

I was going to simply update the metadata

"Programming Language :: Python :: 3.5",

But I saw in commit 0357911 that the minimum required version is specified in multiple other places. This PR is my attempt to update the code and tests to remove any reference to Python versions < 3.7.

A few other notes:

  • In searching old Issues, I found Python 3.5 compatibility - Paths #910. Now that Python 3.5 is no longer supported, I think it can be closed
  • I didn't update any of the tutorials in the documentation since technically a user could install older versions of Snakemake and Python

QC

I don't think this PR requires additional tests or documentation. Please let me know if there is more you'd like me to do.

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester
Copy link
Contributor

johanneskoester commented Mar 23, 2022

Thanks a lot!

@johanneskoester johanneskoester merged commit 62024e2 into snakemake:main Mar 23, 2022
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants