Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix singularity logging messages causing conda fail #1523

Conversation

TanguyLallemand
Copy link
Contributor

@TanguyLallemand TanguyLallemand commented Mar 28, 2022

Description

This modification aims to fix issue #749 and #520. I use the resolution coming from the issue #520.
As a reminder, the problem is that Singularity's logging messages interfere with the verification of the conda version that is done. This solution of @mariafiruleva seems to solve the problem and does not present any side effects

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@johanneskoester johanneskoester changed the title fix singularity logging messages causing conda fail fix: fix singularity logging messages causing conda fail Mar 28, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester merged commit 7797595 into snakemake:main Mar 28, 2022
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants