Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not remove existing temp files in case of dryrun #1543

Merged
merged 1 commit into from Mar 31, 2022

Conversation

johanneskoester
Copy link
Contributor

@johanneskoester johanneskoester commented Mar 31, 2022

Description

fixes #1542

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

visze
visze approved these changes Mar 31, 2022
Copy link

@visze visze left a comment

LGTM. Thank you for the fix!

visze
visze approved these changes Mar 31, 2022
visze
visze approved these changes Mar 31, 2022
@johanneskoester johanneskoester merged commit e820f97 into main Mar 31, 2022
7 checks passed
@johanneskoester johanneskoester deleted the fix/issue1542 branch Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Existing temp() files are deleted on a dry-run
2 participants