Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve dtypes across paramspace #1578

Merged
merged 3 commits into from Apr 21, 2022

Conversation

SichongP
Copy link
Contributor

@SichongP SichongP commented Apr 10, 2022

Description

This PR fixes issue #1574 where when int and float numbers are mixed in paramspace, they are coerced to floats. This is done by replacing iterrows in Paramspace.instance_patterns() with itertuples.

This also updates test_paramspace to include a mixed type paramspace (alpha is now int)

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@SichongP SichongP requested a review from johanneskoester as a code owner Apr 10, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester merged commit 70ce6a0 into snakemake:main Apr 21, 2022
7 checks passed
johanneskoester added a commit that referenced this pull request Apr 21, 2022
@johanneskoester
Copy link
Contributor

johanneskoester commented Apr 21, 2022

@SichongP the testcase fails after merging to main branch. Can you have a look?

@SichongP
Copy link
Contributor Author

SichongP commented Apr 21, 2022

It was caused by the test case pushed by #1299

Should be fixed now @johanneskoester

Would you be able to reopen this or do I need to open a new PR?

@johanneskoester
Copy link
Contributor

johanneskoester commented Apr 22, 2022

thanks, I have pulled your changes in PR #1594!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants