Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid erroneous too early deletion of parent directories in case of failed jobs (thanks to @SichongP). #1601

Merged
merged 6 commits into from May 3, 2022

Conversation

johanneskoester
Copy link
Contributor

@johanneskoester johanneskoester commented Apr 25, 2022

Description

fixes #1261

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2022

Please format your code with black: black snakemake tests/*.py.

@johanneskoester johanneskoester changed the title fix: avoid erroneous too early deletion of parent directories in case of failed jobs. fix: avoid erroneous too early deletion of parent directories in case of failed jobs (thanks to @SichongP). Apr 25, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester merged commit b0917e6 into main May 3, 2022
7 checks passed
@johanneskoester johanneskoester deleted the fix-issue1261 branch May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant