Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove redundant print #1608

Merged
merged 3 commits into from May 2, 2022
Merged

Conversation

Maarten-vd-Sande
Copy link
Contributor

@Maarten-vd-Sande Maarten-vd-Sande commented Apr 27, 2022

Description

When I re-start a workflow with checkpoints, I get spammed with an enormous amount of updating job prints. I think those prints are supposed to be hidden? The other updating job prints are logged under the debug logger:

https://github.com/snakemake/snakemake/blob/main/snakemake/dag.py#L1536

https://github.com/snakemake/snakemake/blob/main/snakemake/dag.py#L1618

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@Maarten-vd-Sande Maarten-vd-Sande changed the title Update dag.py fix: remove redundant print Apr 28, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@johanneskoester johanneskoester merged commit cc7e0e3 into snakemake:main May 2, 2022
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants