Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue 1615 - Switch formatting condition for dictionary #1617

merged 2 commits into from May 2, 2022


Copy link


Fixes issue #1615

A dictionary will return true when using not_iterable from The elif condition is never reached/true in the original code. Swapping them will cause dictionaries to be formatted as expected by snakemake.


  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

I'm not sure how to test this, or if i break any other functionality by changing this.

@LarsStegemanGT LarsStegemanGT changed the title Switch formatting condition for dictionary fix: issue 1615 - Switch formatting condition for dictionary Apr 28, 2022
Copy link

sonarcloud bot commented Apr 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

Thank you so much, good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants