cloud-init: fix strict mode, ensure cloud-init only runs on positive id #15

Merged
merged 1 commit into from Aug 1, 2017

Conversation

Projects
None yet
6 participants
Contributor

raharper commented Jul 6, 2017

cloud-init still runs when no local datasource is present unless we ignore maybe datasources (ones that may be populated later during boot). Core uses strict mode which requires positive identification or cloud-init doesn't run.

Contributor

zyga commented Jul 10, 2017

Does this do the right thing in an actual cloud case?

smoser commented Jul 13, 2017

In short, yes. It does the right thing for as many cases as it can.
In cases where it cannot identify the cloud provider, cloud-init will be disabled. That is not the ideal solution but it does the best it can do with the information available and without polling network resources.

dpb1 commented Jul 27, 2017

Is there a reason that this can't be processed? Waiting on anything from us? thanks!

zyga approved these changes Aug 1, 2017

Looks good to me based on provided feedback.

@ogra1 ogra1 merged commit e0e3997 into snapcore:master Aug 1, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment