fix resize for GPT, be more verbose for logging #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we are missing valuable info in the resize logs, so add -p everywhere - resize2fs fails with the new quoting when $resizeopts is empty (like it was in the GPT case), this issue is fixed as a side effect of adding -p everywhere.
mvo5
approved these changes
Sep 8, 2017
zyga
reviewed
Sep 8, 2017
| @@ -103,11 +103,12 @@ if [ "$min_free_space" -lt "$free_space" ]; then | |||
| gpt) | |||
| # do_gpt needs the device name | |||
| do_gpt "$device" >>$LOGFILE 2>&1 | |||
| resizeopts="-p" | |||
There was a problem hiding this comment.
Can you please add a flag or test ensuring that resizeopts is never empty so that this bug doesn't come back with some refactoring later on. Please include a comment describing why that is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this issue is fixed as a side effect of adding -p everywhere.