/core-build

fix resize for GPT, be more verbose for logging #18

Merged
merged 2 commits into from Sep 8, 2017

Conversation

Reviewers

@zyga zyga

@mvo5 mvo5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ogra1 @zyga @mvo5
@ogra1
Contributor

ogra1 commented Sep 8, 2017

  • we are missing valuable info in the resize logs, so add -p everywhere
  • resize2fs fails with the new quoting when $resizeopts is empty (like it was in the GPT case),
    this issue is fixed as a side effect of adding -p everywhere.
@ogra1
fix resize for GPT, be more verbose for logging 
- we are missing valuable info in the resize logs, so add -p everywhere
- resize2fs fails with the new quoting when $resizeopts is empty (like it was in the GPT case), 
  this issue is fixed as a side effect of adding -p everywhere.

All checks have failed

2 errored checks
continuous-integration/travis-ci/pr — The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push — The Travis CI build could not complete due to an error
Details
2c4761b
@mvo5

mvo5 approved these changes Sep 8, 2017
View changes

initramfs/scripts/local-premount/resize
@@ -103,11 +103,12 @@ if [ "$min_free_space" -lt "$free_space" ]; then
gpt)
# do_gpt needs the device name
do_gpt "$device" >>$LOGFILE 2>&1
+ resizeopts="-p"
@zyga

zyga Sep 8, 2017

Contributor

Can you please add a flag or test ensuring that resizeopts is never empty so that this bug doesn't come back with some refactoring later on. Please include a comment describing why that is needed.

@ogra1
make resizeopts="-p" global, add comment

All checks have failed

1 errored and 1 failing checks
continuous-integration/travis-ci/pr — The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push — The Travis CI build failed
Details
09da7f3
@zyga

zyga approved these changes Sep 8, 2017
View changes

Thanks!

@ogra1 ogra1 merged commit e8bff67 into master Sep 8, 2017
0 of 2 checks passed

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@ogra1 ogra1 deleted the make-resize-verbose-fix-gpt-resize branch Sep 8, 2017

@ogra1 ogra1 restored the make-resize-verbose-fix-gpt-resize branch Sep 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment