Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
add the initramfs-tools-ubuntu-core package source #6
Conversation
ogra1
added some commits
Apr 20, 2017
mvo5
approved these changes
Apr 25, 2017
Looks fine, I still added some comments. Probably best to address in follow-up brances because this is just a verbatim copy of the package. But especially the Vcs-Bzr header we should fix and the others are worth considering as well IMO.
| @@ -0,0 +1,2 @@ | ||
| +[BUILDDEB] | ||
| +native = True |
| +Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com> | ||
| +Build-Depends: debhelper (>= 9), debootstrap, lsb-release, fakeroot, fakechroot | ||
| +Standards-Version: 3.9.5 | ||
| +Vcs-Bzr: lp:ubuntu/initramfs-tools-ubuntu-core |
| +override_dh_auto_test: | ||
| + @set -e; for f in scripts/*; do \ | ||
| + echo "Checking shell syntax of $$f"; \ | ||
| + sh -n $$f; \ |
mvo5
Apr 25, 2017
Contributor
Having shellcheck here would be nice (probably needs some excludes because the file is sourced).
ogra1
Apr 25, 2017
Contributor
i have a branch half ready that uses shellcheck on commits, i didnt want to add shellcheck (universe) to the build deps because that would make a possible MIR harder ...
|
Before I forget, one problem with this approach is that we loose all the (bzr) history. But it looks like we almost have none of this anyway. |
|
the bzr history is exactly one commit "add to bzr" ... not really worth keeping :) |
ogra1
added some commits
Apr 25, 2017
zyga
reviewed
Apr 25, 2017
I have no idea what I'm looking at TBH. I can approve it but it is purely based on trust.
|
@zyga this is simply the current source deb of initramfs-tools-ubuntu-core from the PPA unpacked into the initramfs/ subdir (plus the three changes michael asked about) nothing fancy about it ... |
ogra1 commentedApr 20, 2017
No description provided.