-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bin,debian: include snapd bits from the run system #168
bin,debian: include snapd bits from the run system #168
Conversation
The kernel plugin will need canonical/snapcraft#4200 for things to work as usual. |
This should wait on canonical/snapcraft#4200 to land in snapcraft to avoid build using the plugin to fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this will break building kernel-snaps as they expect to vendor the info file as the top level, and with this change it might not be exposed anymore. Because we copy
cp /usr/lib/ubuntu-core-initramfs/main/usr/lib/snapd/info $(signingv)/snapd-info
so before this lands i should update all the kernel building things to find and use alternative info file location if it doesn't exist.
Or like attempt to extract it from the initrd.
marking this as draft for now. |
This can now land maybe? The kernel plugin was fixed up, and i think i can mass commit change to all the uc22 kernels if we decide to land this branch. |
815ec06
to
a17b1a9
Compare
@xnox yes, I'd like to merge, I've rebased now and marked ready for review. |
Include snap-bootstrap and other files from snapd package when the ubuntu-core-initramfs script is run, instead of when the ubuntu-core-initramfs package is created. So now snapd is a run dependency instead of a build dependency.
a17b1a9
to
e5cb2f1
Compare
Include snap-bootstrap and other files from snapd package when the ubuntu-core-initramfs script is run, instead of when the ubuntu-core-initramfs package is created. So now snapd is a run dependency instead of a build dependency.
Backport of #167