/core

Rename core-support,network-bind plugs to make them unique #32

Merged
merged 3 commits into from Apr 10, 2017

Conversation

Reviewers

@zyga zyga

@ogra1 ogra1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mvo5 @zyga @ogra1
@mvo5
Collaborator

mvo5 commented Apr 7, 2017

Append "-plug" to them so they don't have the same name as the slots.
@mvo5
rename core-support,network-bind plugs to core-support-plg,network-bi… 
…nd-plug to ensure they are uniq and not confused with the slots
ff25274
@mvo5
Collaborator

mvo5 commented Apr 7, 2017

We probably need to do this internally

@mvo5 mvo5 closed this Apr 7, 2017

@zyga
Collaborator

zyga commented Apr 7, 2017

I think we need to do it externally and internally. See snapcore/snapd#3154 for the internal rename.

@mvo5 mvo5 reopened this Apr 7, 2017

@zyga

zyga requested changes Apr 10, 2017
View changes

The change is OK but we need to use different names.

snapcraft.yaml
- plugs:
- - core-support
- - network-bind
+ plugs: [core-support-hook, network-bind-hook]
@zyga

zyga Apr 10, 2017

Collaborator

This should be called core-support-plug and network-bind-plug

@mvo5

mvo5 Apr 10, 2017

Collaborator

Thanks, silly me. Updated.

@zyga

zyga approved these changes Apr 10, 2017
View changes

+1, Thanks

@ogra1

ogra1 approved these changes Apr 10, 2017
View changes

looks fine

@ogra1 ogra1 merged commit 5b211ac into snapcore:master Apr 10, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zyga zyga referenced this pull request in snapcore/snapd Apr 10, 2017

Merged

tests: adjust to look for network-bind-plug #3163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment