/core

install keyring (LP: #1670475), update pkglists #37

Merged
merged 2 commits into from May 9, 2017

Conversation

Reviewers

@zyga zyga

@chipaca chipaca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ogra1 @zyga @chipaca
@ogra1
Contributor

ogra1 commented May 6, 2017 •
Edited 1 time

  • make sure we have a valid archive keyring in place to prevent gpg issues (part of LP: #1670475)
  • force-run apt-get update when we create the classic chroot
  • tests: drop wrong shellcheck version, it runs inside the chroot during build with the right version instead.

ogra1 added some commits May 6, 2017

@ogra1
install keyring (LP: #1670475), update pkglists 
- make sure we have a valid archive keyring in place to prevent gpg issues (part of LP: #1670475)
- force-run apt-get update when we create the classic chroot

All checks have failed

2 errored checks
continuous-integration/travis-ci/pr — The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push — The Travis CI build could not complete due to an error
Details
40c2d16
@ogra1
drop shellcheck from outside the chroot 
shellcheck runs called by snapcraft before the build, there is no need to run it outside in the 14.04 branch.
the 14.04 shellcheck also has a bunch of bugs due to being a very old version and will hit false positives anyway.

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
9927c9a
@zyga

zyga approved these changes May 8, 2017
View changes

Looks sensible. I trust that we run "make check" in the chroot somehow.

@ogra1
Contributor

ogra1 commented May 8, 2017

yes, "make check" is the first thing the snapcraft build calls, and there it does it actually with the correct shellcheck version ;)

@ogra1 ogra1 merged commit 2285822 into master May 9, 2017
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment