Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
remove generated logs, cleaner lsb-release removal #43
Conversation
ogra1
added some commits
May 16, 2017
| @@ -12,7 +12,7 @@ PREFIX=binary/boot/filesystem.dir | ||
| (cd $PREFIX | ||
| mkdir -p var/lib/classic | ||
| apt-get clean | ||
| - apt-get -y install --reinstall -d apt locales base-files libapt-inst2.0 libapt-pkg5.0 ubuntu-keyring | ||
| + apt-get -y install --reinstall -d apt locales base-files libapt-inst2.0 libapt-pkg5.0 ubuntu-keyring lsb-release |
zyga
May 22, 2017
Collaborator
We cannot remove lsb-release, it was allowed under the default apparmor profile so this would constitute a backwards incompatible change. Something do to in core-18 I'm afraid.
ogra1
May 22, 2017
Contributor
this code adds lsb-release to the classic snap tarball, it does not remove anything ...i think you wanted to comment on the code that removes the leftover dpkg cruft for lsb-release ... note that lsb_release itself has never been supported in core and was removed in the same code path before already, the new code just does this cleaner (by using dpkg to also remove the package leftovers)
| - # also remove lsb_release (LP: #1619420) | ||
| - rm -f usr/bin/lsb_release | ||
| + # remove generated logs | ||
| + rm -f var/log/bootstrap.log \ |
morphis
commented
May 22, 2017
|
LGTM |
ogra1
merged commit ba7a06e
into
master
May 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ogra1 commentedMay 16, 2017
•
Edited 1 time
-
ogra1
May 16, 2017