Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
build uboot from source, pull blobs from upstream, use dtbs from archive #11
Conversation
zyga
self-requested a review
Jul 14, 2017
| + mkdir -p $SNAPCRAFT_PART_INSTALL/boot-assets | ||
| + cp u-boot.bin $SNAPCRAFT_PART_INSTALL/boot-assets/uboot.bin | ||
| + tools/mkenvimage -r -s 131072 -o $SNAPCRAFT_PART_INSTALL/boot-assets/uboot.env ../../../uboot.env.in | ||
| + cd $SNAPCRAFT_PART_INSTALL/boot-assets; ln -s uboot.env uboot.conf |
kubiko
Jul 17, 2017
This could be simplified to once call:
ln -s uboot.env $SNAPCRAFT_PART_INSTALL/boot-assets/uboot.conf
| + after: | ||
| + - uboot | ||
| + prepare: | | ||
| + git clone --depth=1 https://github.com/raspberrypi/firmware.git -b stable |
kubiko
Jul 17, 2017
Don't you want to use tag instead of branch here, so we do not accidentally pick new version from upstream without prior testing?
ogra1
Jul 17, 2017
Collaborator
i'm not sure if --depth=1 works with tags, i have to try (the prob is without --depth=1 the checkkout takes between 30 and 45min because it pulls the whole history (vs a few seconds with --depth=1 )
ogra1
added some commits
Jul 17, 2017
| @@ -29,8 +29,8 @@ parts: | ||
| install: | | ||
| mkdir -p $SNAPCRAFT_PART_INSTALL/boot-assets | ||
| cp u-boot.bin $SNAPCRAFT_PART_INSTALL/boot-assets/uboot.bin | ||
| - tools/mkenvimage -r -s 131072 -o $SNAPCRAFT_PART_INSTALL/boot-assets/uboot.env ../../../uboot.env.in | ||
| - ln -s uboot.env $SNAPCRAFT_PART_INSTALL/boot-assets/uboot.conf | ||
| + tools/mkenvimage -r -s 131072 -o $SNAPCRAFT_PART_INSTALL/uboot.env ../../../uboot.env.in |
| + git apply ../../../uboot.patch | ||
| + make rpi_3_32b_defconfig | ||
| + build: | | ||
| + if [ "$(arch)" = "x86_64" ]; then |
ogra1
Jul 27, 2017
•
Collaborator
from coreutils (usually available on all build environments, but if you insist i can add it to build-packages as safety net)
note it is $(arch) ... i.e. the output of /usr/bin/arch ...
ogra1
merged commit 6af80ef
into
snapcore:master
Jul 27, 2017
|
Thanks for doing this @ogra1 -- I'm sorry to not have reviewed it earlier. Looks good. |
ogra1 commentedJul 14, 2017