Skip confinment tests if confinement is disabled #20

Merged
merged 1 commit into from Jun 4, 2016

Conversation

Projects
None yet
2 participants
Collaborator

zyga commented Jun 2, 2016

Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com

Skip confinment tests if confinement is disabled
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Contributor

jdstrand commented Jun 2, 2016

This is fine in general, but you definitely want to test something when confinement is disabled. Testing that something launches at all and that userdata is created come to mind. I suggest adding a test script or two under an 'else' to the 'if STRICT_CONFINEMENT'.

Collaborator

zyga commented Jun 2, 2016

@jdstrand that can be added in the first line as soon as we have that test. I'll add that to my TODO pile

@zyga zyga merged commit c8ee119 into snapcore:master Jun 4, 2016

@zyga zyga deleted the zyga:no-confinement-no-tests branch Jun 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment