/snap-confine

Drop the alternative to ROOTFS_IS_CORE_SNAP #76

Merged
merged 1 commit into from Jul 8, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zyga @jdstrand
@zyga
Collaborator

zyga commented Jul 8, 2016

Since everyone is now shipping this code let’s simplify testing and
remove the old option entirely.
@zyga
Drop the alternative to ROOTFS_IS_CORE_SNAP 
Since everyone is now shipping this code let’s simplify testing and
remove the old option entirely.

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
2844e87
debian/rules
else
- VENDOR_ARGS=--disable-confinement
+ VENDOR_ARGS=--disable-apparmor
endif
@jdstrand

jdstrand Jul 8, 2016

Contributor

These changes don't seem strictly related to this PR but seem ok.

@zyga

zyga Jul 8, 2016

Collaborator

No, they are a manual cherry pick from the debian branch

@jdstrand
Contributor

jdstrand commented Jul 8, 2016

I've not tested this but I like removing code. The code changes LGTM.

@zyga zyga merged commit 21be88f into master Jul 8, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@zyga zyga deleted the drop-old-fs-layout branch Jul 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment