NodeJS plugin #102

Merged
merged 3 commits into from Nov 19, 2015

Conversation

Projects
None yet
3 participants
Collaborator

sergiusens commented Nov 19, 2015

No description provided.

sergiusens added some commits Nov 18, 2015

nodejs plugin: Initial implementation.
This includes a small example.

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
nodejs plugin: support node-packages
This also includes an upstream example using shout.

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

@sergiusens sergiusens changed the title from Nodejs to NodeJS plugin Nov 19, 2015

+logger = logging.getLogger(__name__)
+
+_NODEJS_BASE = 'node-v{version}-linux-{arch}'
+_NODEJS_VERSION = '4.2.2'
@ted-gould

ted-gould Nov 19, 2015

Contributor

Seems like this should be a configuration option, no?

@sergiusens

sergiusens Nov 19, 2015

Collaborator

Yeah, was my plan to do this in the future, as in different PR, this is already too big as it is. Good thing is 4.2.2 is an LTS

+For more information check the 'plugins' topic for the former and the
+'sources' topic for the latter.
+
+Additionally, this plugin uses the following plugin specific keywords:
@chipaca

chipaca Nov 19, 2015

Member

“plugin-specific” (i.e., add a hyphen)

@sergiusens

sergiusens Nov 19, 2015

Collaborator

I'll make a global change for all the plugins with this.

Member

chipaca commented Nov 19, 2015

👍

nodejs plugin: testing added w/ small improvements
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

sergiusens added a commit that referenced this pull request Nov 19, 2015

@sergiusens sergiusens merged commit b5ed4d7 into snapcore:master Nov 19, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 91.986%
Details

@sergiusens sergiusens deleted the sergiusens:nodejs branch Nov 19, 2015

smoser pushed a commit to smoser/snapcraft that referenced this pull request Sep 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment