/snapcraft

python plugin: avoid the use of PYTHON* env vars. #1080

Closed
wants to merge 1 commit into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sergiusens @codecov-io
@sergiusens
Collaborator

sergiusens commented Jan 26, 2017 •
Edited 1 time

Avoid the use of environment variables as they leak into whatever else
calls them. This helps classic confinement but also other things like
snaps with python2 and python3 parts.

PYTHONHOME can be determined by argv0 and PYTHONUSEBASE is setup in site.py

LP: #1657504

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
@sergiusens
python plugin: avoid the use of PYTHON* env vars. 
Avoid the use of environment variables as they leak into whatever else
calls them. This helps classic confinement but also other things like
snaps with python2 and python3 parts.

LP: #1657504

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

All checks have passed

3 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
@snappy-m-o
xenial-amd64 — autopkgtest finished (success)
Details
@snappy-m-o
zesty-amd64 — autopkgtest finished (success)
Details
17dd526
@sergiusens
Collaborator

sergiusens commented Jan 27, 2017

just want to state here that @matiasb gave me a loose 👍 😄
@codecov-io

codecov-io commented Jan 27, 2017

Current coverage is 96.34% (diff: 94.59%)

Merging #1080 into master will decrease coverage by <.01%

@@             master      #1080   diff @@
==========================================
  Files           194        194          
  Lines         17755      17778    +23   
  Methods           0          0          
  Messages          0          0          
  Branches       1368       1369     +1   
==========================================
+ Hits          17107      17129    +22   
  Misses          440        440          
- Partials        208        209     +1

Powered by Codecov. Last update eb884b0...17dd526
@sergiusens
Collaborator

sergiusens commented Jan 30, 2017

Might be replaced with #1093

@sergiusens sergiusens closed this Jan 31, 2017

@sergiusens sergiusens deleted the sergiusens:bugfix/python-plugin-envvars branch Mar 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment