/snapcraft

core: classic with no exported variables. #1090

Closed
wants to merge 2 commits into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sergiusens @codecov-io
@sergiusens
Collaborator

sergiusens commented Jan 28, 2017

To avoid unexpected errors we wipe clean the envrionment
variables inside the wrappers, if a developer needs it
they could export it themselves.

LP: #1657504

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

sergiusens added some commits Jan 26, 2017

@sergiusens
python plugin: avoid the use of PYTHON* env vars. 
Avoid the use of environment variables as they leak into whatever else
calls them. This helps classic confinement but also other things like
snaps with python2 and python3 parts.

LP: #1657504

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

All checks have passed

3 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
@snappy-m-o
xenial-amd64 — autopkgtest finished (success)
Details
@snappy-m-o
zesty-amd64 — autopkgtest finished (success)
Details
17dd526
@sergiusens
core: classic with no exported variables. 
To avoid unexpected errors we wipe clean the envrionment
variables inside the wrappers, if a developer needs it
they could export it themselves.

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

All checks have passed

3 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
@snappy-m-o
xenial-amd64 — autopkgtest finished (success)
Details
@snappy-m-o
zesty-amd64 — autopkgtest finished (success)
Details
7d44e14
@codecov-io

codecov-io commented Jan 28, 2017 •
Edited 1 time

Current coverage is 96.31% (diff: 85.96%)

Merging #1090 into master will decrease coverage by 0.03%

@@             master      #1090   diff @@
==========================================
  Files           194        194          
  Lines         17775      17806    +31   
  Methods           0          0          
  Messages          0          0          
  Branches       1371       1375     +4   
==========================================
+ Hits          17126      17150    +24   
- Misses          440        444     +4   
- Partials        209        212     +3

Powered by Codecov. Last update 9a66ec8...7d44e14
@sergiusens
Collaborator

sergiusens commented Jan 30, 2017

Might be replace with #1093

@sergiusens sergiusens closed this Jan 31, 2017

@sergiusens sergiusens deleted the sergiusens:bugfix/classic-env-vars branch Mar 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment