Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
meta: support for the environment keyword. #1103
+106
−8
Conversation
|
\o/ |
kyrofa
requested changes
Feb 2, 2017
Looks good, but I suggest making the schema a bit more explicit.
| + environment: | ||
| + type: object | ||
| + description: environment entries for the snap as a whole | ||
| + minItems: 1 |
kyrofa
Feb 2, 2017
Member
We should probably catch empty values here. Perhaps by being more explicit:
environment:
type: object
description: environment entries for the snap as a whole
minItems: 1
additionalProperties:
anyOf:
- type: string
minLength: 1
- type: number
| + environment: | ||
| + type: object | ||
| + description: environment entries for the specific app. | ||
| + minItems: 1 |
kyrofa
Feb 2, 2017
Member
We should probably catch empty values here as well. You might consider putting this into definitions so as to not duplicate.
kyrofa
approved these changes
Feb 3, 2017
•
Looks good. Of course the errors are still terrible, but #1059 has ways of improving that as well.
sergiusens
added some commits
Feb 2, 2017
sergiusens
merged commit c66f556
into
snapcore:master
Feb 6, 2017
sergiusens
deleted the
sergiusens:feature/1583259/environment
branch
Feb 6, 2017
added a commit
to elopio/snapcraft
that referenced
this pull request
Feb 10, 2017
added a commit
that referenced
this pull request
Feb 28, 2017
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sergiusens commentedFeb 2, 2017
LP: #1583259
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com