/snapcraft

plainbox-provider plugin: filter out sitecustomize #1139

Merged
merged 2 commits into from Feb 14, 2017

Conversation

Reviewers

@elopio elopio

@kyrofa kyrofa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sergiusens @elopio @kyrofa
@sergiusens
Collaborator

sergiusens commented Feb 13, 2017

When a part that uses the plainbox-provider plugin adds a stage-packages
entry for a python3 package, conflicts will occur as this plugin
most likely always comes after a python part that actually
adds functionality.

Given that sitecustomize.py will be different and the one added
by stage-packages is not really useful in a snap we filter it out.

LP: #1663792

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
@sergiusens
plainbox-provider plugin: filter out sitecustomize 
When a part that uses the plainbox-provider plugin adds a `stage-packages`
entry for a python3 package, conflicts will occur as this plugin
most likely always comes `after` a python part that actually
adds functionality.

Given that sitecustomize.py will be different and the one added
by `stage-packages` is not really useful in a snap we filter it out.

LP: #1663792

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

All checks have failed

3 failing checks
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
@snappy-m-o
xenial-amd64 — autopkgtest finished (failure)
Details
@snappy-m-o
zesty-amd64 — autopkgtest finished (failure)
Details
cf5dcdd
@elopio

elopio approved these changes Feb 13, 2017
View changes

this might be a problem in the future, but I'm ok worrying about it in the future/

@kyrofa

kyrofa approved these changes Feb 13, 2017
View changes

the [sitecustomize.py] added by stage-packages is not really useful in a snap [so] we filter it out.

I'm concerned this won't always be the case, but given the apport-related onces I've seen I'm 👍 on this. Just keep an eye out for bug reports.

@sergiusens
:-(

All checks have passed

3 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
@snappy-m-o
xenial-amd64 — autopkgtest finished (success)
Details
@snappy-m-o
zesty-amd64 — autopkgtest finished (success)
Details
87a55ef

@sergiusens sergiusens merged commit c861ed9 into snapcore:master Feb 14, 2017
3 checks passed

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details

@sergiusens sergiusens deleted the sergiusens:bugfix/1663792/plainbox-site-- branch Feb 14, 2017

elopio added a commit that referenced this pull request Feb 28, 2017

@sergiusens @elopio
plainbox-provider plugin: filter out sitecustomize (#1139) 
When a part that uses the plainbox-provider plugin adds a `stage-packages`
entry for a python3 package, conflicts will occur as this plugin
most likely always comes `after` a python part that actually
adds functionality.

Given that sitecustomize.py will be different and the one added
by `stage-packages` is not really useful in a snap we filter it out.

LP: #1663792

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
bf3d9c4

kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017

@sergiusens
plainbox-provider plugin: filter out sitecustomize (#1139) 
When a part that uses the plainbox-provider plugin adds a `stage-packages`
entry for a python3 package, conflicts will occur as this plugin
most likely always comes `after` a python part that actually
adds functionality.

Given that sitecustomize.py will be different and the one added
by `stage-packages` is not really useful in a snap we filter it out.

LP: #1663792

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
aecb38d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment