Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
kernel plugin: rework MAKEFLAGS from the environment #1150
Conversation
sergiusens
reviewed
Feb 21, 2017
thanks for this, mind looking at the inline comment and updating the unit tests for this?
| # build the software | ||
| - self.run(self.make_cmd + self.make_targets) | ||
| + self.run(self.make_cmd + self.make_targets, env=env) |
piso77
changed the title from
kernel plugin: remove MAKEFLAGS from the environment
to
kernel plugin: rework MAKEFLAGS from the environment
Mar 21, 2017
piso77
added some commits
Mar 21, 2017
sergiusens
merged commit 1409ed2
into
snapcore:master
Mar 22, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
piso77
deleted the
piso77:2.27_fixenv
branch
Mar 24, 2017
added a commit
that referenced
this pull request
Mar 27, 2017
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
piso77 commentedFeb 17, 2017
Linux's kernel Makefile gets confused if it is invoked with the
environment already setup by another Linux's Makefile:
linux/package/Makefile -> snapcraft -> linux/Makefile
fix the problem removing the offending make variable (MAKEFLAGS)
Signed-off-by: Paolo Pisati paolo.pisati@canonical.com
LP: #1665661