go plugin: Add support for cross-compilation #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-maiz
suggested changes
Jun 1, 2017
| if snapcraft.ProjectOptions().deb_arch != 'amd64': | ||
| self.skipTest('The test only handles amd64 to armhf') | ||
|
|
||
| expected_arch = 'arm64' |
There was a problem hiding this comment.
rename to target_arch, please.
| os.path.basename(self.path)) | ||
| arch = subprocess.check_output(['file', '-b', binary], | ||
| universal_newlines=True) | ||
| self.assertThat(arch, Contains('aarch64')) |
There was a problem hiding this comment.
Kyle and Sergio think that this will be better as a matcher in this branch.
| 'go-hello') | ||
| binary = os.path.join(self.parts_dir, 'go-hello', 'install', 'bin', | ||
| os.path.basename(self.path)) | ||
| arch = subprocess.check_output(['file', '-b', binary], |
There was a problem hiding this comment.
use python magic instead of file.
snapcraft/tests/plugins/test_go.py
Outdated
|
|
||
| patcher = mock.patch('sys.stdout') | ||
| patcher.start() | ||
| self.addCleanup(patcher.stop) |
There was a problem hiding this comment.
This shouldn't be needed, it's done by the base test case.
come-maiz
approved these changes
Jun 1, 2017
This was referenced Jun 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support doing
snapcraft snap --target-arch=with parts using the go plugin