Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
snapcraft.yaml: add support for reload-command and completer directives #1373
Conversation
bloodearnest
changed the title from
Add support in snapcraft yaml for reload-command directive
to
snapcraft.yaml: add support in snapcraft yaml for reload-command directive
Jun 21, 2017
bloodearnest
changed the title from
snapcraft.yaml: add support in snapcraft yaml for reload-command directive
to
snapcraft.yaml: add support for reload-command directive
Jun 21, 2017
|
Thanks @bloodearnest! This looks good to me, but it needs a review from somebody from the snapd team. I see no documentation about reload-command, and last time we did this, we added a value that was supported in snapd but undocumented on purposed because people were not supposed to use it. @zyga maybe? Want to take a quick look here? |
kalikiana
requested a review
from
zyga
Jun 23, 2017
bloodearnest
changed the title from
snapcraft.yaml: add support for reload-command directive
to
snapcraft.yaml: add support for reload-command and completer directives
Jun 27, 2017
|
Updated branch to also allow completer directive, for bash completion. As supported by snapd here: https://github.com/snapcore/snapd/blob/master/snap/info_snap_yaml.go#L64 |
|
Also, the system doesn't seem to know I'm a canonical employee, so It thinks I havn't signed the CLA |
|
Have cleaned up branch to just single commit |
|
You have a gmail address in GitHub, that's why the CLA check doesn't recognize you. There's two ways to fix it:
|
|
Ah, thanks. Have signed as IC. |
|
Yeah, I don't see it here https://forum.snapcraft.io/t/the-snap-format/698/2?u=sergiusens |
| @@ -187,6 +190,9 @@ properties: | ||
| - type: string | ||
| minLength: 1 | ||
| - type: number | ||
| + completer: |
sergiusens
Jul 4, 2017
Collaborator
please remove this, there is a specific branch adding support for this with user guidance.
bloodearnest commentedJun 21, 2017
•
Edited 1 time
-
bloodearnest
Jun 27, 2017
reload-command and completer fields are supported in snapd, but not snapcraft
Checklist:
Yes, am canonical employee
LP: #1699507
yes