snapcraft.yaml: add support for reload-command and completer directives #1373

Merged
merged 1 commit into from Jul 26, 2017

Conversation

Projects
None yet
4 participants
Contributor

bloodearnest commented Jun 21, 2017

reload-command and completer fields are supported in snapd, but not snapcraft

Checklist:

  • Have you signed the contributor licence agreement?

Yes, am canonical employee

  • Is there a reported a bug for the problem you are fixing?

LP: #1699507

  • Have you read our contribution guide?

yes

@bloodearnest bloodearnest changed the title from Add support in snapcraft yaml for reload-command directive to snapcraft.yaml: add support in snapcraft yaml for reload-command directive Jun 21, 2017

@bloodearnest bloodearnest changed the title from snapcraft.yaml: add support in snapcraft yaml for reload-command directive to snapcraft.yaml: add support for reload-command directive Jun 21, 2017

Member

elopio commented Jun 22, 2017

Thanks @bloodearnest! This looks good to me, but it needs a review from somebody from the snapd team. I see no documentation about reload-command, and last time we did this, we added a value that was supported in snapd but undocumented on purposed because people were not supposed to use it.

@zyga maybe? Want to take a quick look here?

@kalikiana kalikiana requested a review from zyga Jun 23, 2017

@bloodearnest bloodearnest changed the title from snapcraft.yaml: add support for reload-command directive to snapcraft.yaml: add support for reload-command and completer directives Jun 27, 2017

Contributor

bloodearnest commented Jun 27, 2017

Updated branch to also allow completer directive, for bash completion.

As supported by snapd here:

https://github.com/snapcore/snapd/blob/master/snap/info_snap_yaml.go#L64

Contributor

bloodearnest commented Jun 27, 2017

Also, the system doesn't seem to know I'm a canonical employee, so It thinks I havn't signed the CLA

Contributor

bloodearnest commented Jun 27, 2017

Have cleaned up branch to just single commit

Collaborator

kalikiana commented Jun 30, 2017

You have a gmail address in GitHub, that's why the CLA check doesn't recognize you. There's two ways to fix it:

  • Sign the CLA with your gmail address
  • Change your GitHub email to a Canonical address
Contributor

bloodearnest commented Jun 30, 2017

Ah, thanks. Have signed as IC.

schema/snapcraft.yaml
@@ -187,6 +190,9 @@ properties:
- type: string
minLength: 1
- type: number
+ completer:
@sergiusens

sergiusens Jul 4, 2017

Collaborator

please remove this, there is a specific branch adding support for this with user guidance.

Add support in snapcraft yaml for reload-command
reload-command and completer directives are supported in snapd, but not
snapcraft.

@sergiusens sergiusens added this to the 2.33 milestone Jul 26, 2017

@sergiusens sergiusens merged commit 48a347e into snapcore:master Jul 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

kalikiana added a commit to kalikiana/snapcraft that referenced this pull request Aug 3, 2017

meta: add support for `reload-command` (#1373)
The `reload-command` directive is supported in snapd, but not
snapcraft.

kalikiana added a commit to kalikiana/snapcraft that referenced this pull request Sep 21, 2017

meta: add support for `reload-command` (#1373)
The `reload-command` directive is supported in snapd, but not
snapcraft.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment