meta: add `base` as a type and top level property #1419

Merged
merged 8 commits into from Aug 15, 2017

Conversation

3 participants
Contributor

mvo5 commented Jul 26, 2017

Thanks for helping us make a better Snapcraft!

LP: #1706564

Collaborator

sergiusens commented Jul 26, 2017

Thanks for the contribution. The tests failed because your commit in the email has not signed the CLA, you can either sign it with your @ubuntu.com account or use your @canonical.com email to author the commit.

@mvo5 mvo5 referenced this pull request in snapcore/snapd Jul 26, 2017

Merged

many: end-to-end support for the bare base snap #3625

Contributor

mvo5 commented Jul 26, 2017

The contributor agreement thing is hopefully sorted now.

Thanks for the change @mvo5!
This needs a user test. Ideally, this would call snapcraft with a different base and execute it. We have snaps_tests for this things, but I'm not sure how easy would it be to automate. If it's too complex, we always have manual_tests.md

@sergiusens sergiusens added this to the 2.34 milestone Aug 3, 2017

In the branch on snapd where you mention the dependency on this one you also use base as a type. I don't see that reflected here.

@sergiusens sergiusens changed the title from add "base" to the snapcraft.yaml schema to meta: add `base` as a type and top level property Aug 3, 2017

Contributor

mvo5 commented Aug 9, 2017

Thanks for the feedback and sorry for the delay, I was on vacation.

I added the "base" to the support types now and also added tests to snaps_tests as suggested. This will validate that the snaps can be build and installed. If you need more tests, please let me know.

the tests were added

@sergiusens sergiusens merged commit 024b920 into snapcore:master Aug 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sergiusens sergiusens added this to Integration in 17.10 Aug 15, 2017

kalikiana added a commit to kalikiana/snapcraft that referenced this pull request Sep 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment