Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
meta: add `base` as a type and top level property #1419
Conversation
|
Thanks for the contribution. The tests failed because your commit in the email has not signed the CLA, you can either sign it with your @ubuntu.com account or use your @canonical.com email to author the commit. |
mvo5
referenced this pull request
in snapcore/snapd
Jul 26, 2017
Merged
many: end-to-end support for the bare base snap #3625
|
The contributor agreement thing is hopefully sorted now. |
elopio
reviewed
Jul 28, 2017
Thanks for the change @mvo5!
This needs a user test. Ideally, this would call snapcraft with a different base and execute it. We have snaps_tests for this things, but I'm not sure how easy would it be to automate. If it's too complex, we always have manual_tests.md
sergiusens
added this to the 2.34 milestone
Aug 3, 2017
sergiusens
requested changes
Aug 3, 2017
In the branch on snapd where you mention the dependency on this one you also use base as a type. I don't see that reflected here.
sergiusens
changed the title from
add "base" to the snapcraft.yaml schema
to
meta: add `base` as a type and top level property
Aug 3, 2017
mvo5
added some commits
Aug 9, 2017
|
Thanks for the feedback and sorry for the delay, I was on vacation. I added the "base" to the support types now and also added tests to snaps_tests as suggested. This will validate that the snaps can be build and installed. If you need more tests, please let me know. |
mvo5
added some commits
Aug 15, 2017
sergiusens
dismissed
elopio’s
stale review
Aug 15, 2017
the tests were added
mvo5 commentedJul 26, 2017
Thanks for helping us make a better Snapcraft!
LP: #1706564