Syntax of snapcraft.yaml (1.x) #146

Merged
merged 1 commit into from Dec 18, 2015

Conversation

Projects
None yet
4 participants
Contributor

dholbach commented Dec 3, 2015

No description provided.

Member

elopio commented Dec 4, 2015

You have a weird diff in here. I'm not sure how to help, I would just copy the .md files to /tmp, delete everything and try again :)

Member

kyrofa commented Dec 4, 2015

@elopio they look okay to me... which diff is weird?

Member

elopio commented Dec 4, 2015

@kyrofa on files changed I see examples/tomcat-maven-webapp/snapcraft.yaml, integration-tests/units/jobs.pxu, snapcraft/cmds.py, ...
Things that come from other PRs.

Member

kyrofa commented Dec 4, 2015

Ah, yeah this looks like it needs a rebase.

Contributor

dholbach commented Dec 4, 2015

Ok, I think I managed to do the rebase. O:-)

+ * `version` (string)
+ The version of the resulting snap.
+ * `vendor` (string)
+ Vendor in email format as defined in RFC 5322.
@kyrofa

kyrofa Dec 8, 2015

Member

Would it be worth mentioning that this is deprecated here?

@dholbach

dholbach Dec 16, 2015

Contributor

I think at some stage we'll just phase out the 1.x docs(?). With snapcraft 0.6 it's still required, right?

@kyrofa

kyrofa Dec 16, 2015

Member

Yeah, okay that makes sense.

docs/snapcraft-syntax.md
+ explanation for the snap.
+ * `config` (string)
+ Path to the runnable in snap that will be used as the Snappy config
+ interface.
@kyrofa

kyrofa Dec 8, 2015

Member

I personally (a relative newcomer to snappy) am not familiar with this. Have I missed a document, or should this section contain a reference link?

Member

kyrofa commented Dec 16, 2015

I'm good with this. @dholbach would you mind squashing?

Contributor

dholbach commented Dec 17, 2015

Done.

Member

kyrofa commented Dec 17, 2015

@elopio, @sergiusens I'd like to get an OK from at least one of you before this merges.

docs/snapcraft-syntax.md
+ [Snappy packaging spec](https://developer.ubuntu.com/snappy/guides/packaging-format-apps/).
+ * `icon` (string)
+ Path to the icon that will be used for the snap.
+ * `license` (yaml subsection)
@sergiusens

sergiusens Dec 18, 2015

Collaborator

this isn't actually implemented so I'd just remove it.

elopio added a commit that referenced this pull request Dec 18, 2015

@elopio elopio merged commit 46ce501 into snapcore:1.x Dec 18, 2015

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
coverage/coveralls Coverage remained the same at 90.141%
Details

@dholbach dholbach deleted the dholbach:syntax-of-snapcraft.yaml-1.x branch Jan 19, 2016

smoser pushed a commit to smoser/snapcraft that referenced this pull request Sep 14, 2016

porting fix from issue #146 to the 2.0 agent in the 2.1 branch; note …
…that in the 2.1 agent itself, fileutil.write_file uses utf-8 encoding by default, therefore the same bug should not exist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment