/snapcraft

cli: build command migrated to docopts #149

Merged
merged 1 commit into from Dec 4, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sergiusens @elopio
@sergiusens
Collaborator

sergiusens commented Dec 3, 2015

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
snapcraft/lifecycle.py
+ if step == 'pull':
+ part.pull()
+ elif step == 'build':
+ part.build()
@elopio

elopio Dec 3, 2015

Member

would something like getattr(part, step)(), too obscure?

snapcraft/tests/test_commands_build.py
+from snapcraft.commands import build
+
+
+class PullCommandTestCase(tests.TestCase):
@elopio

elopio Dec 3, 2015

Member

BuildCommandTestCase.

@elopio
Member

elopio commented Dec 3, 2015

lgtm. Just one copy&paste error.
@sergiusens
cli: build command migrated to docopts 
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.6%) to 80.738%
Details
807287a

sergiusens added a commit that referenced this pull request Dec 4, 2015

@sergiusens
Merge pull request #149 from sergiusens/08-docopts-build 
cli: build command migrated to docopts
ffcb9c7

@sergiusens sergiusens merged commit ffcb9c7 into snapcore:new-cli Dec 4, 2015
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.6%) to 80.738%
Details

@sergiusens sergiusens deleted the sergiusens:08-docopts-build branch Dec 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment