Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: implement :target suffix for package names #1536

Closed
wants to merge 8 commits into from

Conversation

kalikiana
Copy link
Contributor

@kalikiana kalikiana commented Sep 7, 2017

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh unit?

Fixes: #1502
Related: LP: #1737561

@kalikiana kalikiana self-assigned this Sep 7, 2017
@kyrofa
Copy link
Contributor

kyrofa commented Sep 12, 2017

(tests are failing)

@kalikiana
Copy link
Contributor Author

kalikiana commented Sep 13, 2017

These failures aren't mine: ERROR: test_build_maven_plugin (test_maven_plugin.MavenPluginTestCase) test_maven_plugin.MavenPluginTestCase.test_build_maven_plugin BlockingIOError: [Errno 11] write could not complete without blocking. I'll restart the job again.

@kalikiana
Copy link
Contributor Author

kalikiana commented Sep 15, 2017

Once more... apparently there's also a legitimate test_cross_compiling_with_cgo_and_target_suffix in there now.

@kalikiana
Copy link
Contributor Author

Latest error output is this E: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/xenial-updates/main/binary-arm64/Packages 404 Not Found [IP: 91.189.88.152 80] so somehow the default sources are broken? I don't know how to test this... will close for now and discuss other options.

@kalikiana kalikiana closed this Oct 11, 2017
@lool
Copy link
Contributor

lool commented Dec 18, 2017

(Is this the best place to discuss implementation?)

Just wanted to say that :target is nice and useful, but:

  1. it would make sense to default to :target for stage-packages (and to build architecture for build-packages)
  2. hence it might make sense to offer :build and or :host architectures as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants