Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Make it possible to use the cmake ninja generator #1579
+297
−48
Conversation
kalikiana
reviewed
Oct 5, 2017
Nice refactor! Got some small comments, but looking pretty good so far!
| +# You should have received a copy of the GNU General Public License | ||
| +# along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| + | ||
| +import os |
kalikiana
Oct 5, 2017
Collaborator
Please run ./runtests.sh static locally. You're importing but not using os and shutils and there's some too long lines (you can also see it in the Travis results).
| + return self.options.configflags | ||
| + | ||
| + def runCompilation(self): | ||
| + pass # raise? |
sergiusens
added this to the 2.36 milestone
Oct 26, 2017
sergiusens
removed this from the 2.36 milestone
Nov 14, 2017
|
Thanks for the contribution, the unit tests are failing and there hasn't been much movement on this so I am going to close for now. Feel free to reopen once the necessary fixes are made. |
sergiusens
closed this
Dec 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
aleixpol commentedSep 29, 2017
Refactors the cmake plugin into a base class that will be used by the make
and ninja variants.
Includes a ninja plugin that can potentially be reused by others