Make it possible to use the cmake ninja generator #1579
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalikiana
reviewed
Oct 5, 2017
| # You should have received a copy of the GNU General Public License | ||
| # along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| import os |
There was a problem hiding this comment.
Please run ./runtests.sh static locally. You're importing but not using os and shutils and there's some too long lines (you can also see it in the Travis results).
| return self.options.configflags | ||
|
|
||
| def runCompilation(self): | ||
| pass # raise? |
There was a problem hiding this comment.
Should this be raise NotImplementedError()?
Refactors the cmake plugin into a base class that will be used by the make and ninja variants. Includes a ninja plugin that can potentially be reused by others
|
Thanks for the contribution, the unit tests are failing and there hasn't been much movement on this so I am going to close for now. Feel free to reopen once the necessary fixes are made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the cmake plugin into a base class that will be used by the make
and ninja variants.
Includes a ninja plugin that can potentially be reused by others