tests: add the slow tag for ros snapd integration test

[elopio]

• Have you followed the guidelines for contributing?
• Have you signed the CLA?
• If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
• If this is a new feature. Have you discussed the design on the forum?
• Have you successfully run ./runtests.sh static?
• Have you successfully run ./runtests.sh unit?

---

Requires #1603

[kyrofa]

This looks excellent. I do have one question: What if we have slow integration tests outside of the snapd suite? Should the slow_test attribute be moved up a class?

[elopio]

@kyrofa if that happens, we need to talk about it. The other suites shouldn't be slow, ideally. If we need it, we just move the var to the parent class and add it to the debian control.

[kalikiana]

Nice and simple. I like it!

[sergiusens]

can someone re-trigger the failing test jobs?

[kalikiana]

@sergiusens This won't pass on zesty without #1614.

ERROR: test_catkin_shared_ros.CatkinSharedRosTestCase.test_shared_ros_builds_without_catkin_in_underlay [...] apt.cache.FetchFailedException: W:GPG error: http://packages.ros.org/ros/ubuntu xenial InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 5523BAEEB01FA116, E:The repository 'http://packages.ros.org/ros/ubuntu xenial InRelease' is not signed. [...]

[kyrofa]

We're skipping instead, as in #1621, which has now landed. I just updated the branch, and will re-run the tests.

[sergiusens]

all implementations in here set it as a class attribute instead of in setUp. While working it is confusing and potentially error prone.

[elopio]

I think it makes it less error prone to put it as a class attribute, because that assignment will always run before setUp.

From your comment, it's not clear what's your preference. I could document that the slow_test = True must be set in a class attribute, which is not totally correct, but could make it easier to understand.

[sergiusens]

looks good