Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
cross compilation: enable cross compilation of i386 kernel on x86-64 … #1613
Conversation
and others
added some commits
Oct 12, 2017
kalikiana
self-requested a review
Oct 13, 2017
kalikiana
approved these changes
Oct 13, 2017
Nice trick there!
Thanks for looking into this.
| + # to start the build | ||
| + if (self.__platform_arch == 'x86_64' and | ||
| + self.__target_machine == 'i686'): | ||
| + return |
kyrofa
Oct 13, 2017
Member
This doesn't just apply to the kernel though, right? Do the other build systems handle this appropriately? @kalikiana that may be a question for you.
kalikiana
Oct 13, 2017
Collaborator
It's only used by the kbuild plugin which the kernel plugin subclasses afair. Nothing else uses that value.
kalikiana
Oct 13, 2017
Collaborator
self.project.arch_triplet is used elsewhere - it may be something to consider for the future if it should be re-used in other places, I don't recall if there was a specific reason for this.
kalikiana
Oct 19, 2017
Collaborator
Either one is good. But as this came up twice, I changed it to ''.
| + # to start the build | ||
| + if (self.__platform_arch == 'x86_64' and | ||
| + self.__target_machine == 'i686'): | ||
| + return |
kyrofa
Oct 13, 2017
Member
This doesn't just apply to the kernel though, right? Do the other build systems handle this appropriately? @kalikiana that may be a question for you.
kalikiana
Oct 13, 2017
Collaborator
It's only used by the kbuild plugin which the kernel plugin subclasses afair. Nothing else uses that value.
kalikiana
Oct 13, 2017
Collaborator
self.project.arch_triplet is used elsewhere - it may be something to consider for the future if it should be re-used in other places, I don't recall if there was a specific reason for this.
kalikiana
Oct 19, 2017
Collaborator
Either one is good. But as this came up twice, I changed it to ''.
piso77 commentedOct 12, 2017
•
Edited 1 time
-
sergiusens
Oct 13, 2017
…hosts
Signed-off-by: Paolo Pisati paolo.pisati@canonical.com
https://bugs.launchpad.net/snapcraft/+bug/1563363
./runtests.sh static?./runtests.sh unit?Fixes: bug 1563363