Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
kernel plugin: use latest stable core snap #1624
Conversation
|
Thanks @alfonsosanchezbeato! This will need the eyes of @sergiusens. Changing to |
ogra1
approved these changes
Oct 17, 2017
we might perhaps want to keep the same channel here ... to not make the turnaround time for script fixes longer than they have to be ...
beyond that ... pretty please merge this... thats a gross oversight ...
|
Yeah, the only reason this wasn't done faster was that I was hoping for the initrd split to happen sooner. |
|
If you want to level-up on the task, maybe also update to use the correct path in the os (core, base) snap -> LP: #1567564 |
|
On mar, oct 17, 2017 at 12:28 PM, Oliver Grawert ***@***.***> wrote:
@ogra1 approved this pull request.
we might perhaps want to keep the same channel here ... to not make
the turnaround time for script fixes longer than they have to be ...
beyond that ... pretty please merge this... thats a gross oversight
...
Well, choose, merge it now or change the channel and then merge? ;-)
…
|
That's a two-way street-- breakages come faster, too. I'd personally like to see |
|
I am more on the side of using stable too... it is not fun to have a build suddenly breaking because core's daily build added broken scripts. |
|
Updated to try to fix the integration tests. |
ogra1
commented
Oct 18, 2017
|
well, being democratically overruled, lets merge it with "stable" ... someone with permission needs to do that though ... |
sergiusens
added this to the 2.35 milestone
Oct 18, 2017
sergiusens
added
the
bug
label
Oct 18, 2017
sergiusens
approved these changes
Oct 18, 2017
Thanks, you changed everything to core, which is also appreciated.
The only reason we used edge was because at the time of writing of this plugin, stable wasn't really a thing.
alfonsosanchezbeato commentedOct 17, 2017
The plugin was downloading ubuntu-core instead of core, which is
nowadays a very old version of the later.