kernel plugin: use latest stable core snap #1624

Merged
merged 2 commits into from Oct 18, 2017

Conversation

4 participants
Contributor

alfonsosanchezbeato commented Oct 17, 2017

The plugin was downloading ubuntu-core instead of core, which is
nowadays a very old version of the later.

Member

kyrofa commented Oct 17, 2017

Thanks @alfonsosanchezbeato! This will need the eyes of @sergiusens. Changing to core seems obvious, but I don't remember the argument for using edge over stable.

ogra1 approved these changes Oct 17, 2017

we might perhaps want to keep the same channel here ... to not make the turnaround time for script fixes longer than they have to be ...

beyond that ... pretty please merge this... thats a gross oversight ...

kernel plugin: use latest stable core snap
The plugin was downloading ubuntu-core instead of core, which is
nowadays a very old version of the later. Test updated as well.
Collaborator

sergiusens commented Oct 17, 2017

Yeah, the only reason this wasn't done faster was that I was hoping for the initrd split to happen sooner.

Collaborator

sergiusens commented Oct 17, 2017

If you want to level-up on the task, maybe also update to use the correct path in the os (core, base) snap -> LP: #1567564

Collaborator

sergiusens commented Oct 17, 2017

Member

kyrofa commented Oct 18, 2017

we might perhaps want to keep the same channel here ... to not make the turnaround time for script fixes longer than they have to be ...

That's a two-way street-- breakages come faster, too. I'd personally like to see stable used, here.

Contributor

alfonsosanchezbeato commented Oct 18, 2017

I am more on the side of using stable too... it is not fun to have a build suddenly breaking because core's daily build added broken scripts.

Contributor

alfonsosanchezbeato commented Oct 18, 2017

Updated to try to fix the integration tests.

ogra1 commented Oct 18, 2017

well, being democratically overruled, lets merge it with "stable" ... someone with permission needs to do that though ...

@sergiusens sergiusens added this to the 2.35 milestone Oct 18, 2017

@sergiusens sergiusens added the bug label Oct 18, 2017

Thanks, you changed everything to core, which is also appreciated.

The only reason we used edge was because at the time of writing of this plugin, stable wasn't really a thing.

@sergiusens sergiusens merged commit aa8a842 into snapcore:master Oct 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment