/snapcraft

lifecycle: split into its own package #1626

Merged
merged 1 commit into from Oct 18, 2017

Conversation

Reviewers

@elopio elopio

Assignees

@sergiusens sergiusens

Labels
None yet
Projects
17.10 (awaiting triage)
Milestone
  2.35
3 participants
@sergiusens @kyrofa @elopio
@sergiusens
Collaborator

sergiusens commented Oct 17, 2017 •
Edited 1 time

This is a small refactor to make the lifecycle module
a bit more manageable and separate some concerns
for the logic within it.

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh unit?

This is as minimally invasive as possible, but required to make the lifecycle logic navigate-able again to build on top of.
@sergiusens
lifecycle: split into its own package 
This is a small refactor to make the lifecycle module
a bit more manageable and separate some concerns
for the logic within it.

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
936d6f6
@kyrofa
Member

kyrofa commented Oct 17, 2017

\o/
snapcraft/internal/lifecycle/_clean.py
+ shutil.rmtree(constants.SNAPCRAFT_INTERNAL_DIR)
+
+
+def clean(project_options, parts, step=None):
@elopio

elopio Oct 18, 2017

Member

It would be nice to reorder the functions in this file to be readable from top to bottom.
But no need to do it here, I like that kind of refactor so I can take the opportunity later to do it and document something in the CODE_STYLE.md

@elopio

elopio approved these changes Oct 18, 2017
View changes

I like this. Thank you.

@sergiusens sergiusens added this to the 2.35 milestone Oct 18, 2017

@sergiusens sergiusens self-assigned this Oct 18, 2017

@sergiusens sergiusens merged commit 5aab678 into snapcore:master Oct 18, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sergiusens sergiusens deleted the sergiusens:package-lifecycle branch Oct 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment