/snapcraft

snap: remove leaking LD_LIBRARY_PATH #1635

Merged
merged 1 commit into from Oct 21, 2017

Conversation

Reviewers

@sergiusens sergiusens

Assignees

@kyrofa kyrofa

Labels
bug
Projects
17.10 (awaiting triage)
Milestone
  2.35
2 participants
@kyrofa @sergiusens
@kyrofa
Member

kyrofa commented Oct 20, 2017 •
Edited 1 time

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh unit?

This PR fixes LP: #1723208 by removing the LD_LIBRARY_PATH set in the snapcraft-classic wrapper. This leaks into the running environment and causes the snap on other distros to break (e.g. Trusty). It also seems completely unnecessary given the rpaths.
@kyrofa
snap: remove leaking LD_LIBRARY_PATH 
This leaks into the running environment and causes the snap on other
distros to break (e.g. Trusty). It also seems completely unnecessary
given the rpaths.

LP: #1723208

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
This commit was signed with a verified signature.
@kyrofa kyrofa Kyle Fazzari
GPG key ID: A7D23FB0E778DEDF Learn about signing commits

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
@snappy-m-o
xenial-amd64 — autopkgtest finished (success)
Details
14b6d3d
@sergiusens

sergiusens approved these changes Oct 21, 2017
View changes

oh my, I wonder how this ever got in there! Or how it stayed, it never occurred to me to look here for that.

@sergiusens sergiusens merged commit da91814 into snapcore:master Oct 21, 2017
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details

@sergiusens sergiusens added this to the 2.35 milestone Oct 21, 2017

@sergiusens sergiusens assigned kyrofa Oct 21, 2017

@sergiusens sergiusens added the bug label Oct 21, 2017

elopio added a commit to elopio/snapcraft that referenced this pull request Oct 23, 2017

@kyrofa @elopio
snap: remove leaking LD_LIBRARY_PATH (#1635) 
This leaks into the running environment and causes the snap on other
distros to break (e.g. Trusty). It also seems completely unnecessary
given the rpaths.

LP: #1723208

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
e70cf68

@sergiusens sergiusens referenced this pull request Oct 23, 2017

Merged

libraries: exclude the full set of libc6 #1632

6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment