Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Python{2,3} plugins: Make site-packages link relative. #169
Conversation
elopio
reviewed
Dec 17, 2015
| - os.path.join(prefix, 'lib', self.python_version, | ||
| - 'dist-packages'), | ||
| - site_packages_dir) | ||
| + os.symlink('dist-packages', site_packages_dir) |
kyrofa
Dec 17, 2015
Member
Ah, good call, I didn't even look at python3. Fixing now. I'm going to go ahead and include the fix in this PR since it's small and I'd say it's the same bug.
|
I think we should have an integration test for this too, simplifying the snapcraft that was mentioned in the bug. Feel free to open a bug for it so we can write it in python once #166 lands. |
|
@elopio yeah good idea, both on the test and on waiting, heh. The new bug: https://bugs.launchpad.net/snapcraft/+bug/1527270 |
kyrofa
changed the title from
Python2 plugin: Make site-packages link relative.
to
Python{2,3} plugins: Make site-packages link relative.
Dec 17, 2015
kyrofa
added
the
bug
label
Dec 17, 2015
|
|
added a commit
that referenced
this pull request
Dec 18, 2015
sergiusens
merged commit 68257b9
into
snapcore:master
Dec 18, 2015
kyrofa
deleted the
kyrofa:bugfix/1523384/make_site_packages_relative_link
branch
Dec 18, 2015
kyrofa
referenced this pull request
Dec 18, 2015
Merged
Cherry-pick for 1.x: Python{2,3} plugins: Make site-packages link relative. #171
pushed a commit
to smoser/snapcraft
that referenced
this pull request
Sep 14, 2016
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
kyrofa commentedDec 16, 2015
Currently the Python2 and Python3 plugins create a
<install>/usr/lib/<pythonversion>/site-packagessymlink to<install>/usr/lib/<pythonversion>/dist-packages, but that absolute link doesn't exist when the .snap is installed. This commit makes the link relative instead of absolute so the link stays valid.This may be worth cherry-picking to 1.x.
Fixes LP: #1523384